fix(anvil): tag newly created legacy transactions on shadow fork as Some(0) (0x0) rather than None
#9195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
changed the title
anvil): tag legacy transactions as Some(0) (0x0) rather than Noneanvil): tag legacy transactions as Some(0) (0x0) rather than None
zerosnacks
changed the title
anvil): tag legacy transactions as Some(0) (0x0) rather than Noneanvil): tag newly created legacy transactions as Some(0) (0x0) rather than None
zerosnacks
changed the title
anvil): tag newly created legacy transactions as Some(0) (0x0) rather than Noneanvil): tag newly created legacy transactions on shadow fork as Some(0) (0x0) rather than None
zerosnacks
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
yash-atreya
as code owners
klkvr
reviewed
Oct 25, 2024
klkvr
approved these changes
Oct 25, 2024
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
… `Some(0)` (`0x0`) rather than `None` (foundry-rs#9195) * mark legacy transaction type as 0x0 or Some(0) rather than None * return as Some(0) for legacy tx * revert Some(0) change per EIP-2718 spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #9194
Solution
Mark legacy transaction type as
0x0orSome(0)rather thanNoneThis is in line with how Alloy marks legacy transactions
Steps to test:
In other window send a new transaction w/ default Anvil keys):
To verify the fix run step 2 with latest
anvilinstallWill now correctly yield:
{ "hash": "0x4dd5234b264e33221ef96a782163da179dcdc86a33f36f368aff8464ff17baa8", "nonce": "0x2f9a", "blockHash": "0x85ee456c35a65eccbd00ce99071a7aa79779770a52257cbaef4ef267f27254d8", "blockNumber": "0x69ed48", "transactionIndex": "0x0", "from": "0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266", "to": "0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266", "value": "0x0", "gasPrice": "0xe7f2d0db", "gas": "0x5209", "input": "0x", "r": "0xfe3f4a9323506eb34d6e38d15eebdfee9999d9355a40de7107cb19ad652623ae", "s": "0xdb65c223098cd4b7c8a032cc3958eb609fc1d0db7b64e83cacde5ace2217e99", "v": "0x1546d72", "chainId": "0xaa36a7", "type": "0x0" }as opposed to
{ "hash": "0xe29dedc1f322c74923c409e5a4c66db6a9106d4ba765c7ba35c63bbdd826346e", "nonce": "0x2f9a", "blockHash": "0xf5836152445dc0421b15e0e3a4de9f37a0e85361fe6d9913497c2b7181876e88", "blockNumber": "0x69ed4e", "transactionIndex": "0x0", "from": "0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266", "to": "0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266", "value": "0x0", "gasPrice": "0x10abcce5d", "gas": "0x5209", "input": "0x", "r": "0x950a20008eb86b40c582ed1b909e30cea67a887bf04202507213000efef99ea8", "s": "0x7f3e167a3281e08823d5900847236505627bbf590fe8c9b45a61a78e3c4b2a68", "v": "0x1546d72", "chainId": "0xaa36a7" }When querying existing legacy transactions the
transaction_typeis already correctly marked as0x0.