feat(anvil): support mining with same block.timestamp
#9160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
|
@mattsse this effectively undos the fix for #6096. See here: foundry/crates/anvil/tests/it/anvil_api.rs Line 611 in 0d9d8a5 If users expect the |
mattsse
approved these changes
Oct 22, 2024
domob1812
added a commit
to xaya/xayax
that referenced
this pull request
Oct 25, 2024
Anvil now (foundry-rs/foundry#9160) supports blocks with constant timestamp, so there is no need to explicitly bump the mock time when generating a new block (it can remain the same). This simplifies testing logic potentially, as tests do not need to expect increasing timestamps after setting a mock time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #9142 + Closes #7931
Solution
Replace the check
next_timestamp <= last_timestampwithnext_timestamp < last_timestamp.Anvil can now mine blocks with the same timestamp as the previous block timestamp. This aids in running forks or testing chains that have sub-second block times, wherein
block.timestampstays constant until exactly one second has passed.Added relevant tests.