fix(anvil): arb fork mining
#9153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
mattsse
requested changes
Oct 21, 2024
Comment on lines
2957
to
2964
| pub fn is_arbitrum(chain_id: u64) -> bool { | ||
| if let Ok( | ||
| NamedChain::Arbitrum | | ||
| NamedChain::ArbitrumGoerli | | ||
| NamedChain::ArbitrumNova | | ||
| NamedChain::ArbitrumTestnet, | ||
| ) = NamedChain::try_from(chain_id) | ||
| { |
There was a problem hiding this comment.
we could upstream this to alloy-chains as well
mattsse
approved these changes
Oct 21, 2024
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
* fix(`anvil`): use header.number not best_number * test * ignore test_arbitrum_fork_block_number * fix(`anvil`): miner logic for arb-like chains * clippy * test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #9152
Solution
While mining blocks on arbitrum forks set the
env.block.numberusingstorage.best_numberasenv.block.numberactually representsl1BlockNumberand not the arbitrum block number.