feat(forge build): add initcode size check
#9116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 15, 2024 00:16
mgiagante
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
added 2 commits
October 15, 2024 03:24
|
Finally! Thank you ser 🫡 Tested and worked to me! |
grandizzy
requested changes
Oct 15, 2024
grandizzy
changed the title
grandizzy
changed the title
forge build): add initcode size check
grandizzy
reviewed
Oct 15, 2024
grandizzy
reviewed
Oct 15, 2024
grandizzy
approved these changes
Oct 15, 2024
zerosnacks
reviewed
Oct 15, 2024
DaniPopes
requested changes
Oct 16, 2024
mds1
reviewed
Oct 16, 2024
|
@DaniPopes Please let me know if this needs any further improvements before it can be merged. Thank you! |
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
* Adds init code size limit check & column to table. * Adds option to ignore init code size check during --size output. * Updates tests with new column for --sizes table. * Adds test helpers for forge CLI. * Implements test for init code size limit as per EIP-3860 * Adds test for --ignore-eip-3860 * Fixes for Cargo +nightly fmt warnings. * Refactors both contract size functions into one with a boolean arg. * Adds alias for --ignore-eip-3860 to --ignore-initcode-size. * Brings back the original comments. * Update compile.rs * Changes --ignore-eip-3860 to be a boolean field. * Fixes ranges in table display code and comment punctuation. * Moves testing helper to existing utils module. * Improve ranges in table display code. * Adds output assertions to initcode size check tests. * Minor change to ranges in display logic for sizes table. --------- Co-authored-by: mgiagante <[email protected]> Co-authored-by: zerosnacks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4783
described in the Additional Context of this comment
Motivation
Prior to EIP-3860 there was no size limit on creation code (initcode), and just a 24576 byte size limit on runtime code.
EIP-3860 went live in Shangai so now there is both:
Currently,
forge build --sizesdoes not account for this new size limit.Solution
forge build --sizesfor the contract init code size (bytes) and the margin left counting towards the limit (bytes).--ignore-eip-3860allows to ignore the check mentioned in the previous point. This is aimed to users deploying to chains that do not enforce this limit.Testing