Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fmt): do not panic when no named arg #9114

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix(fmt): do not panic when no named arg #9114

merged 1 commit into from
Oct 14, 2024

Conversation

grandizzy
Copy link
Collaborator

Motivation

Closes #9113

Solution

  • handle case when no named parameter passed

@grandizzy grandizzy marked this pull request as ready for review October 14, 2024 18:45
@grandizzy grandizzy enabled auto-merge (squash) October 14, 2024 18:45
@grandizzy grandizzy merged commit 440837d into foundry-rs:master Oct 14, 2024
21 checks passed
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
@grandizzy @rplusq
fix(fmt): do not panic when no named arg (foundry-rs#9114)
a0236f2
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
C-forge Command: forge T-bug Type: bug
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(forge fmt): formatter crash on empty named parameter block
2 participants
@grandizzy @mattsse