Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forge): allow passing value to --optimize #9071

Merged
merged 1 commit into from
Oct 9, 2024
Merged

feat(forge): allow passing value to --optimize #9071

merged 1 commit into from
Oct 9, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Oct 9, 2024 •
edited
Loading

Motivation

There's no way to disable optimizer through CLI

Solution

Allows passing value to --optimize flag, e.g --optimize=false

grandizzy
grandizzy approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@klkvr klkvr merged commit 641132f into master Oct 9, 2024
21 checks passed
@klkvr klkvr deleted the klkvr/optimize-false branch October 9, 2024 10:57
@klkvr klkvr self-assigned this Oct 14, 2024
@grandizzy grandizzy added T-feature Type: feature C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArkFunds ArkFunds ArkFunds approved these changes

@zerosnacks zerosnacks zerosnacks approved these changes

@grandizzy grandizzy grandizzy approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees

@klkvr klkvr

Labels
C-forge Command: forge T-feature Type: feature
Projects
Foundry
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klkvr @grandizzy @zerosnacks @ArkFunds