-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make --gas-report
JSON output compatible
#9063
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
yash-atreya
as code owners
October 8, 2024 10:31
2 tasks
grandizzy
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
DaniPopes
requested changes
Oct 9, 2024
ping @DaniPopes for final review |
DaniPopes
approved these changes
Oct 10, 2024
Hey folks, I just tried running this command and imo there's multiple issues with that implementation:
|
Hi @sakulstra thanks for your feedback, I've opened a new ticket here with your points as feature requests: #9111 assigned to me |
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
* add gas report generation in JSON * skip junit for now * add json formatted tests, trailing space and invalid formatting * avoid redundant modifications for calls count * replace existing tests with snapbox * clean up snapbox tests * merge in master * calls -> frames * use .is_jsonlines()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #8789
Part of meta-ticket #8794
Solution
Updates existing relevant tests to use Snapbox and adds additional tests for JSON output
Adds an additonal check on
--gas-report
when the--junit
flag is specified as JUnit output is not supportedAdds a
silent
variable to mute unexpected output, this can be expanded in the future for other outputs that are mutually exclusive with the standard outputEach test suite ran with
--json
is written to an individual line to allow users to easily consume the output by parsing by line.JSON formatted output looks like this:
Compare to Markdown output: