feat: update to Soldeer v0.4.0 #9014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mario-eth
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
mattsse
reviewed
Oct 3, 2024
beeb
approved these changes
Oct 5, 2024
DaniPopes
reviewed
Oct 7, 2024
DaniPopes
changed the title
|
Blocked on mario-eth/soldeer#202 + release |
mattsse
reviewed
Oct 7, 2024
crates/forge/tests/cli/soldeer.rs
Outdated
Comment on lines
27
to
35
| ◆ Done reading config | ||
| │ | ||
| [6A[1A | ||
| [2K[1B[1A◇ Installing forge-std~1.8.1 | ||
| [6B◆ Dependency added to config | ||
| │ | ||
| ◆ Dependency added to lockfile | ||
| │ | ||
| ◆ Dependency added to remappings |
There was a problem hiding this comment.
looks like we need to escape ◇ here
There was a problem hiding this comment.
Removing the control characters before the diamonds also works, but yeah probably easier to just wildcard it
mattsse
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We finally have the version 0.4.0 ready.
In 0.4.0 we kinda did a rewrite to have it more rust idiomatic and solved also bugs that were waiting to be fixed.
mario-eth/soldeer#202
Full description of the release!
Important mention:
we did split the project into 3 crates:
soldeeraloneWe did not publish the crates yet as we are waiting for feedback here beforehand.
Solution