Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anvil): backwards compatible dumps #8752

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

bernard-wagner
Copy link
Contributor

@bernard-wagner bernard-wagner commented Aug 27, 2024

Motivation

Fixes #8501

Solution

#8411 broke backwards compatibility of anvil state dumps. This PR allows anvil to handle both new and old dump formats.

Some additional test

Passes

git checkout 31628d1457f28405c8aa98751ac933f10a95b1c1 && git checkout HEAD^ # commit before PR #8411 
git cherry-pick 8e5001dcef4139a21f6a4ef31c902774d51eec66 # cherry-pick tests
cargo test --package anvil --test it -- state::can_load_existing_state_legacy

Fails

git checkout master
git cherry-pick 8e5001dcef4139a21f6a4ef31c902774d51eec66  # cherry-pick tests
cargo test --package anvil --test it -- state::can_load_existing_state_legacy

@bernard-wagner bernard-wagner marked this pull request as ready for review August 27, 2024 13:09
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@mattsse mattsse merged commit 5d2ac1a into foundry-rs:master Aug 27, 2024
20 checks passed
@noahlitvin
Copy link

@bernard-wagner thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(anvil): anvil_loadState fails to decode state dump after upgrading to new foundry version
3 participants