Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump alloy to use get_receipt hotfix #7772

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

yash-atreya
Copy link
Member

Motivation

Use get_receipt hotfix from updated alloy version.

Solution

Bump

@yash-atreya yash-atreya marked this pull request as ready for review April 24, 2024 20:14
@yash-atreya yash-atreya self-assigned this Apr 24, 2024
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's likely something wrong with script or the send logic of alloy

looks like sending tx no requires an explicit setter for the to field for create txs

@yash-atreya
Copy link
Member Author

there's likely something wrong with script or the send logic of alloy

looks like sending tx no requires an explicit setter for the to field for create txs

Yes likely

@yash-atreya yash-atreya requested a review from mattsse April 24, 2024 23:28
@DaniPopes DaniPopes merged commit e01038f into foundry-rs:master Apr 25, 2024
20 checks passed
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few pedantic nits, can be done in a followup

crates/anvil/core/src/eth/transaction/mod.rs Show resolved Hide resolved
crates/anvil/src/eth/api.rs Show resolved Hide resolved
crates/anvil/src/eth/backend/mem/mod.rs Show resolved Hide resolved
crates/cast/bin/cmd/call.rs Show resolved Hide resolved
crates/cast/bin/cmd/estimate.rs Show resolved Hide resolved
crates/cast/bin/tx.rs Show resolved Hide resolved
@yash-atreya
Copy link
Member Author

Suggestions addressed in #7701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants