fix: always compile sources when running scripts #7738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Apr 20, 2024
tynes
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Apr 22, 2024
Updates foundry to `63fff3510408b552f11efb8196f48cfe6c1da664` which includes foundry-rs/foundry#7738. This fixes the issue foundry-rs/foundry#7732 which was preventing #10106 from just working. Props to the foundry devs for fixing our issues very quickly, unblocking our ability to ship. Need to follow up with a bump to `ci-builder` such that it includes this release of foundry and then rebase #10106 on top so that it can pass tests.
github-merge-queue bot
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Apr 22, 2024
Updates foundry to `63fff3510408b552f11efb8196f48cfe6c1da664` which includes foundry-rs/foundry#7738. This fixes the issue foundry-rs/foundry#7732 which was preventing #10106 from just working. Props to the foundry devs for fixing our issues very quickly, unblocking our ability to ship. Need to follow up with a bump to `ci-builder` such that it includes this release of foundry and then rebase #10106 on top so that it can pass tests.
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #7732, similar to #7572
Solution
I believe we should add a way for files to "import" other sources into compiler input other than Solidity imports to allow such setups with
getCode. Something like #7025 should work (but I don't really like this exact approach)