Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forge): add tree command #771

Merged
merged 6 commits into from
Mar 9, 2022
Merged

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Feb 19, 2022

BLOCKED BY gakonst/ethers-rs#933

Motivation

add forge tree

Solution

@onbjerg onbjerg added the T-feature Type: feature label Feb 19, 2022
@gakonst
Copy link
Member

gakonst commented Feb 28, 2022

Nice! There seems to be some bug with subtree alignment, see forge tree --no-dedupe for https://github.com/gakonst/dapptools-template. Maybe also happens without dedup though?

telegram-cloud-photo-size-2-5226437843444939478-y

@mattsse
Copy link
Member Author

mattsse commented Mar 8, 2022

forgot about this...

can't spot what's wrong in the image 🙈

is it these branches @gakonst?
image

Otherwise the dedupe graph seems correct

@gakonst
Copy link
Member

gakonst commented Mar 9, 2022

Yes exactly @mattsse it's the branches under src/Greeter.sol, which appear twice

The other one that seems wrong is the one below GreeterTest.sol, doesn't seem like it should have the little leg left of the test.sol path, and should just be a |_?
image

@mattsse
Copy link
Member Author

mattsse commented Mar 9, 2022

Ref gakonst/ethers-rs#999

Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumped ethers, tested with a couple repos, lgtm

@gakonst gakonst merged commit 4b3a729 into foundry-rs:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature Type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants