Add transient storage warning to default ignored_error_codes
#7299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Totally supportive personally but looking for @mattsse @DaniPopes confirmation
DaniPopes
approved these changes
Mar 4, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The warning generated by solc when compiling code that uses the new
tstore/tloadopcodes is not particularly useful or productive. The solc team has shown no interest in removing the warning from the compiler.Solution
Default Forge behavior should be to ignore this warning, as no other (non-deprecated) opcodes get this treatment.