Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cast): add wallet sign --no-hash #7180

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

DaniPopes
Copy link
Member

Closes #6794

Open to naming changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think --no-hash is fine

pending @klkvr

@mattsse mattsse requested a review from klkvr February 20, 2024 09:54
Copy link
Member

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

this will cause conflicts with #7141, but it's nbd since WalletSigner haven't changed much

@DaniPopes DaniPopes merged commit 644e31e into master Feb 20, 2024
19 checks passed
@DaniPopes DaniPopes deleted the dani/wallet-sign-hash branch February 20, 2024 10:33
klkvr pushed a commit to klkvr/foundry that referenced this pull request Feb 20, 2024
* feat(cast): add `wallet sign --no-hash`

* doc

* doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vm.sign and cast wallet sign produce different signatures given the same data.
3 participants