chore: remove unused imports #7170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
approved these changes
Feb 19, 2024
onbjerg
reviewed
Feb 19, 2024
| @@ -410,7 +385,7 @@ pub mod wrapper { | |||
| #[serde(rename = "gasUsed")] | |||
| pub gas_used: Option<U256>, | |||
| /// Contract address created, or `None` if not a deployment. | |||
| #[serde(rename = "contractAddress", serialize_with = "serialize_opt_addr")] | |||
There was a problem hiding this comment.
serialize fns don't do anything different than default impl
There was a problem hiding this comment.
default impl does checksum? if so, all good, think this was just leftover from ethers
There was a problem hiding this comment.
Ah you're right, we wrapped to checksum, I don't know why but I'll keep it
DaniPopes
force-pushed
the
dani/unused-imports
branch
2 times, most recently
from
7f8b9e0 to
65dda6e
Compare
DaniPopes
force-pushed
the
dani/unused-imports
branch
from
dc22cfe to
2d75e71
Compare
onbjerg
approved these changes
Feb 19, 2024
mattsse
approved these changes
Feb 19, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.