-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] feat: provider alloy migration #7106
Conversation
* feat(foundry-common): NameOrAddress ENS util * chore: rename err * chore: remove from impl for str * chore: unrelated fix from alloy upgrade * nit
* chore: add alloy contract * feat(cast): migrate most methods to alloy * chore: leave todo for converting a tx envelope into an rpc tx * fix: use proper type for storage * readd decodetx for now * chore: extend txbuilder to build an alloy tx request * feat: migrate most methods bar send/decode raw tx * fix: include tx data * simplify txbuilder * chore: simplify back access_list * chore: remove unnecesary conversion * fmt * doctests * fmt * do not use trait * Update crates/cast/bin/main.rs Co-authored-by: Matthias Seitz <[email protected]> * cleanup builder * clippy * fix doc comments --------- Co-authored-by: Matthias Seitz <[email protected]>
Cast now compiles and ethers is almost gone. We are still using it in 2 places:
There are still a lot of errors coming from various places. At the first glance most of them are coming from anvil due to alloy bump and changed transaction types. Will work on that next cc @mattsse |
e9e7e4f
to
c734de4
Compare
blocked by deser issues, should be fixed by alloy-rs/alloy#474 |
alloy-rs/alloy#474 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's send it and do more incremental followups
(Some(1), _, None, None, _, None, None, None) | | ||
(None, _, None, None, Some(_), None, None, None) => { | ||
(Some(1), _, None, None, _, None, None, None, _) | | ||
(None, _, None, None, Some(_), None, None, None, _) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can do this but separately
failing test unrelated I believe |
#7594 needs to be merged into this before we merge this PR EDIT: Should be g2g! |
* refactor cast logs to use alloy * fmt * make clippy happy * cleanup * doc nits --------- Co-authored-by: evalir <[email protected]>
Motivation
This migrates anvil, cast and most of the forge to use alloy providers and primitive types on all methods.
Closes #7486
Closes #7400
Closes #5709
Closes #7089
Solution
NameOrAddress
ENS support with CLI utility (feat(foundry-common
): NameOrAddress ENS util #7122)