Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cast): cast wallet & cast run alloy migration #7088

Merged
merged 11 commits into from
Feb 13, 2024
Merged

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented Feb 12, 2024

Migrates parts of cast, namely, cast wallet and cast run, to alloy.

@Evalir Evalir marked this pull request as ready for review February 12, 2024 18:14
@Evalir Evalir changed the title feat(cast): cast wallet alloy migration feat(cast): cast wallet & cast run alloy migration Feb 12, 2024
@Evalir Evalir requested a review from onbjerg February 12, 2024 18:36
@Evalir
Copy link
Member Author

Evalir commented Feb 12, 2024

ci failure unrelated.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nits

pending @DaniPopes

crates/cast/bin/cmd/run.rs Show resolved Hide resolved
crates/cast/bin/cmd/run.rs Outdated Show resolved Hide resolved
crates/cast/bin/cmd/run.rs Outdated Show resolved Hide resolved
crates/cast/bin/cmd/run.rs Outdated Show resolved Hide resolved
crates/cast/bin/cmd/run.rs Outdated Show resolved Hide resolved
crates/cast/bin/cmd/wallet/vanity.rs Outdated Show resolved Hide resolved
crates/cast/src/lib.rs Outdated Show resolved Hide resolved
crates/cast/bin/cmd/wallet/mod.rs Outdated Show resolved Hide resolved
@Evalir Evalir requested a review from DaniPopes February 13, 2024 14:26
crates/cast/src/lib.rs Outdated Show resolved Hide resolved
@Evalir Evalir requested a review from DaniPopes February 13, 2024 14:45
@Evalir Evalir merged commit 29ad753 into master Feb 13, 2024
18 of 20 checks passed
@Evalir Evalir deleted the evalir/cast-alloy-mig branch February 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants