Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build arm64 linux nightlies #694

Merged
merged 4 commits into from
Feb 8, 2022
Merged

ci: build arm64 linux nightlies #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9581b2
ci: build arm64 linux nightlies
onbjerg Feb 7, 2022
4314eac
fix: disable solc autodetection on arm
onbjerg Feb 8, 2022
cc81ee1
fix: add autodetect warning on arm devices
onbjerg Feb 8, 2022
ad4106f
ci: install `gcc-aarch64-linux-gnu` for arm builds
onbjerg Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,15 @@ jobs:
# The OS is used for the runner
# The platform is a generic platform name
# The target is used by Cargo
# The arch is either 386 or amd64
# The arch is either 386, arm64 or amd64
- os: ubuntu-latest
platform: linux
target: x86_64-unknown-linux-gnu
arch: amd64
- os: ubuntu-latest
platform: linux
target: aarch64-unknown-linux-gnu
arch: arm64
- os: macos-latest
platform: darwin
target: x86_64-apple-darwin
Expand Down Expand Up @@ -112,6 +116,12 @@ jobs:
echo "SDKROOT=$(xcrun -sdk macosx --show-sdk-path)" >> $GITHUB_ENV
echo "MACOSX_DEPLOYMENT_TARGET=$(xcrun -sdk macosx --show-sdk-platform-version)" >> $GITHUB_ENV

- name: Linux ARM setup
if: ${{ matrix.job.target == 'aarch64-unknown-linux-gnu' }}
run: |
sudo apt-get update -y
sudo apt-get install -y gcc-aarch64-linux-gnu

- name: Build binaries
env:
RUSTFLAGS: -C link-args=-s
Expand Down
11 changes: 11 additions & 0 deletions cli/src/cmd/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,10 +197,21 @@ impl Provider for BuildArgs {
dict.insert("libs".to_string(), libs.into());
}

#[cfg(not(target_arch = "aarch64"))]
if self.no_auto_detect {
dict.insert("auto_detect_solc".to_string(), false.into());
}

#[cfg(target_arch = "aarch64")]
{
if !self.no_auto_detect {
println!("Solidity compiler autodetection is disabled on ARM.");
println!("You can track progress on ARM support in https://github.com/gakonst/foundry/issues/525");
println!("To silence this warning use --no-auto-detect");
}
dict.insert("auto_detect_solc".to_string(), false.into());
}

if self.force {
dict.insert("force".to_string(), self.force.into());
}
Expand Down