Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function output decoding #6526

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix function output decoding #6526

merged 1 commit into from
Dec 5, 2023

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Dec 5, 2023

Motivation

Fixes bug introduced in #6504 which breaks decoding of function outputs

mattsse
mattsse approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks correct

pending @Evalir @DaniPopes

Evalir
Evalir approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@DaniPopes DaniPopes merged commit 9093207 into foundry-rs:master Dec 5, 2023
19 checks passed
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Evalir approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klkvr @mattsse @Evalir @DaniPopes