Add --save-path Option to VanityArgs for Custom Wallet File Saving
#6475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeesura
requested review from
DaniPopes,
Evalir and
mattsse
as code owners
|
You need to format with nightly |
Thank you very much for your assistance and guidance! I successfully formatted my code using the cargo +nightly fmt command, and now everything conforms to the project's formatting standards. Your support throughout this process has been invaluable. |
|
Updated test and made the option write directly to the given path rather than appending a file name to it |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation of the cast wallet vanity generation tool (VanityArgs struct) lacks the flexibility of specifying a custom file path for saving generated wallet details. Users who need to organize their wallet information in specific directories, or those managing multiple wallets, are currently limited to the tool's default behavior of saving these details in the current working directory. This limitation can be inconvenient for users who require more control over where their wallet details are stored.
Solution
This PR introduces the save_path option to the VanityArgs struct, providing users the ability to specify a custom path for saving their wallet details. The implementation updates the run method within the VanityArgs struct to handle the logic for saving the wallet details at the user-specified path. If no path is specified, the wallet details will be saved in the current working directory, maintaining the existing default behavior.