Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add cast proof test #6403

Merged
merged 2 commits into from
Nov 22, 2023
Merged

test: add cast proof test #6403

merged 2 commits into from
Nov 22, 2023

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Nov 22, 2023 •
edited by DaniPopes
Loading

@mattsse mattsse force-pushed the matt/add-proof-test branch from 735bc30 to 06f6aa1 Compare November 22, 2023 17:49
@mattsse mattsse mentioned this pull request Nov 22, 2023
Closed
@mattsse mattsse changed the title Matt/add proof test test: add cast proof test Nov 22, 2023
@DaniPopes
Copy link
Member

Can you also add 0x1 0x01 or something which is not padded

@mattsse mattsse merged commit 7fcb730 into foundry-rs:master Nov 22, 2023
19 checks passed
excaliborr
excaliborr reviewed Nov 22, 2023
View reviewed changes
Copy link

@excaliborr excaliborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is the proofs that are generated from 0 and bytes32(0) are not the same, I found this when verifying them against an MPT where the proof from cast proof 0 reverts and cast proof bytes32(0) was a valid proof, thats why I was updating the documentation

@mattsse
Copy link
Member Author

mattsse commented Nov 22, 2023

hmm, odd, as shown here both are parsed the same

@excaliborr
Copy link

excaliborr commented Nov 22, 2023 •
edited
Loading

hmm, odd, as shown here both are parsed the same

Ok so my above comment is wrong, both proofs are the same however the proof I get from my eth_getProof rpc when RLP encoding generates the correct output from an MPT, but the proof from cast proof causes my MPT to revert is there a chance this is a known issue?

@excaliborr
Copy link

Ok I figured it out, it ended up being error in my scripts interacting with cast proof sorry for the confusion

This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@excaliborr excaliborr excaliborr left review comments

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @DaniPopes @excaliborr