Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows ci part 69 #6283

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix: windows ci part 69 #6283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/test-utils/src/util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ pub fn run_install_commands(root: &Path) {
let mut cmd = Command::new(args[0]);
cmd.args(&args[1..]).current_dir(root);
eprintln!("cd {}; {cmd:?}", root.display());
#[cfg(windows)]
let st = cmd.status();
#[cfg(not(windows))]
let st = cmd.status().unwrap();
Comment on lines +101 to 104
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm tossing my pc out of the window if this is really what is screwing up windows ci

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just that this panics because Windows can't find the commands, and the only test that actually requires these commands is snekmate.
I added this in #6277

eprintln!("\n\n{cmd:?}: {st:?}");
};
Expand Down
Loading