Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cast/send): legacy txn sending #605

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Jan 27, 2022

Mostly good i think but hitting this issue after upgrading ethers-rs with cargo update -p ethers

cargo run --bin forge           
   Compiling ethers-providers v0.6.0 (https://github.com/gakonst/ethers-rs#c22dd8ea)
error[E0433]: failed to resolve: use of undeclared crate or module `http`
   --> /Users/tarrence/.cargo/git/checkouts/ethers-rs-c3a7c0a0ae0fe6be/c22dd8e/ethers-providers/src/transports/http.rs:162:27
    |
162 |     InvalidHeader(#[from] http::header::InvalidHeaderValue),
    |                           ^^^^ use of undeclared crate or module `http`

For more information about this error, try `rustc --explain E0433`.
error: could not compile `ethers-providers` due to previous error

@onbjerg onbjerg added the T-feature Type: feature label Jan 27, 2022
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nit

cli/src/cmd/create.rs Outdated Show resolved Hide resolved
@mattsse
Copy link
Member

mattsse commented Jan 27, 2022

Mostly good i think but hitting this issue after upgrading ethers-rs with cargo update -p ethers

cargo run --bin forge           
   Compiling ethers-providers v0.6.0 (https://github.com/gakonst/ethers-rs#c22dd8ea)
error[E0433]: failed to resolve: use of undeclared crate or module `http`
   --> /Users/tarrence/.cargo/git/checkouts/ethers-rs-c3a7c0a0ae0fe6be/c22dd8e/ethers-providers/src/transports/http.rs:162:27
    |
162 |     InvalidHeader(#[from] http::header::InvalidHeaderValue),
    |                           ^^^^ use of undeclared crate or module `http`

For more information about this error, try `rustc --explain E0433`.
error: could not compile `ethers-providers` due to previous error

looks like this gakonst/ethers-rs#829 broke something

ah, here:

https://github.com/gakonst/ethers-rs/pull/829/files#diff-2d4418116321b8da3a56e7f37ae11b4b2ed50f031e24d8a87d9f4d234cd970e0R27

crate http is optional and only enabled for ws

https://github.com/gakonst/ethers-rs/pull/829/files#diff-2d4418116321b8da3a56e7f37ae11b4b2ed50f031e24d8a87d9f4d234cd970e0R65

but used here

https://github.com/gakonst/ethers-rs/pull/829/files#diff-9d1bf55195e9bdfb5252063b81a5579275fb8e689640629e9cfc1c151b68abdcR157-R167

we should make the http non optional

Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@gakonst gakonst merged commit 28679a1 into foundry-rs:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature Type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants