-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cast/send): legacy txn sending #605
Conversation
78d168a
to
81b8daf
Compare
81b8daf
to
c67c5d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smol nit
looks like this gakonst/ethers-rs#829 broke something ah, here: crate http is optional and only enabled for but used here we should make the |
c67c5d8
to
e629c33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work
Mostly good i think but hitting this issue after upgrading ethers-rs with
cargo update -p ethers