-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Otterscan support #5414
Merged
Merged
Changes from 21 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
a119ceb
Implementing Otterscan support
naps62 7b6871b
comments
naps62 6205a0e
code review
naps62 34b966d
code review
naps62 93bcbd9
code review
naps62 e0dea78
code review
naps62 c80fab8
Merge branch 'master' into ots
naps62 88feee7
code review
naps62 664b54a
Some fixes
naps62 00e085e
code review
naps62 7350691
Merge branch 'master' into ots
naps62 25db0cc
Update anvil/src/eth/otterscan.rs
naps62 0d38757
code review
naps62 52e03f4
code review
naps62 460d598
ots_getBlockDetailsByHash
naps62 b10230a
search endpoints tests
naps62 ac835bf
tests for ots_getBlockTransactions
naps62 1d79382
tests for ots_getBlockDetails
naps62 432d89f
code review
naps62 9b11ebf
code review
naps62 0520337
code review
naps62 3ad752e
code review
naps62 9d652cb
code review
naps62 92659cd
code review
naps62 045f397
code review
naps62 0ba605f
code review
naps62 006555f
code review
naps62 76f226b
code review
naps62 3789fd2
code review
naps62 658d0f4
Merge branch 'master' into ots
naps62 751e88d
code review
naps62 2542ba8
code review
naps62 864e3b1
code review
naps62 3aba8d6
code review
naps62 9caf3fb
code review
naps62 52e94a8
code review
naps62 293496e
Merge branch 'master' into ots
naps62 50cf28b
code review
naps62 53dcf44
Update Cargo.toml
naps62 4aafc9b
code review
naps62 5444bc9
clippy
Evalir 9519f9f
code review
naps62 486c71d
code review
naps62 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,3 +30,4 @@ default = [] | |
impersonated-tx = [] | ||
fastrlp = ["dep:open-fastrlp"] | ||
serde = ["dep:serde"] | ||
otterscan = [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be called so? If so, can we add a bit of context as to why it has erigon naming? not super familiar with otterscan so just wanna make sure we have this documented 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I documented the
impl EthApi
functions, but now that you mention, probably most of those comments belong here insteadAs for this particular one, it's otterscan being a bit sneaky and making an erigon-specific call on load to "check if we're connected to an erigon node". In practice I think they could achieve the same result (show a proper error msg when the node isnt' supported) by using ay other ots_ endpoint, but oh well.
Perhaps I'll change that upstream later. for now it's reported here, waiting for input: otterscan/otterscan#1081