Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds polygon-mainnet and polygon-mumbai #438

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

nickbytes
Copy link
Contributor

@nickbytes nickbytes commented Jan 13, 2022

Adds polygon-mainnet and polygon-mumbai.

Genesis Hashes
mainnet:
https://polygonscan.com/block/0

mumbai:
https://mumbai.polygonscan.com/block/0

Test
mainnet:
ETH_RPC_URL=https://polygon-rpc.com cargo run --bin cast chain

mumbai:
ETH_RPC_URL=https://rpc-mumbai.matic.today cargo run --bin cast chain

Used @joshieDo's PR as reference

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cast/src/lib.rs Outdated
@@ -349,6 +349,12 @@ where
"0x6341fd3daf94b748c72ced5a5b26028f2474f5f00d824504e4fa37a75767e177" => "rinkeby",
"0xbf7e331f7f7c1dd2e05159666b3bf8bc7a8a3a9eb1d518969eab529dd9b88c1a" => "goerli",
"0x14c2283285a88fe5fce9bf5c573ab03d6616695d717b12a127188bcacfc743c4" => "kotti",
"0xa9c28ce2141b56c474f1dc504bee9b01eb1bd7d1a507580d5519d4437a97de1b" => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed that the naming for mainnet differs from ethers-rs

https://github.com/gakonst/ethers-rs/blob/19671e51deefec4c8f384270dd9141290a4f65b9/ethers-core/src/types/chain.rs#L95-L96

we should probably support both variants there

Copy link
Contributor Author

@nickbytes nickbytes Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to be polygon. Noticed seth also has it as polygon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

polygon seems to be an outlier without -mainnet

@gakonst gakonst merged commit bd1b7cd into foundry-rs:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants