feat(script): simulate mining on the onchain simulation with --slow
#2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Jul 26, 2022
I don't think so. Given that it's the onchain simulation, i'd say that's the recommended way actually. |
|
smol merge conflict @joshieDo then good 2 merge |
mattsse
approved these changes
Jul 26, 2022
2 tasks
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Nov 9, 2022
…foundry-rs#2481) * increment block.number on onchain simulation with --slow * add doc to executor.build_env
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ref #2474
And should also close #1902 to my understanding. ( @naps62 )
Solution
Increment
block.numberin between calls during the onchain simulation.