Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): replace underscore for hyphen on wallet cli args #212

Merged
merged 1 commit into from
Dec 12, 2021
Merged

fix(cli): replace underscore for hyphen on wallet cli args #212

merged 1 commit into from
Dec 12, 2021

Conversation

joshieDo
Copy link
Collaborator

_ vs - were causing clap-rs to panic if some requirements were not met, instead of giving a proper error:

ETH_FROM=$ADDR cargo run --bin cast -- send  $ADDR "get()"

thread 'main' panicked at 'Fatal internal error. Please consider filing a bug report at https://github.com/clap-rs/clap/issues', ~/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-2.33.3/src/app/usage.rs:475:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

mattsse
mattsse approved these changes Dec 12, 2021
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch.
+1 on using - style

@gakonst gakonst merged commit 910b50f into foundry-rs:master Dec 12, 2021
@joshieDo joshieDo deleted the fix/underscore-args branch December 12, 2021 17:39
mario-eth added a commit to mario-eth/foundry-soldeer that referenced this pull request Oct 11, 2024
@mario-eth
Hotfix foundry-rs#212
17db89d
zerosnacks pushed a commit that referenced this pull request Oct 11, 2024
@mario-eth
feat: update to Soldeer v0.4.1 (#9092)
44b2d75 
Hotfix #212
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
@mario-eth @rplusq
feat: update to Soldeer v0.4.1 (foundry-rs#9092)
71ca4e8 
Hotfix foundry-rs#212
@grandizzy grandizzy added T-bug Type: bug C-cast Command: cast labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
C-cast Command: cast T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshieDo @gakonst @mattsse @grandizzy