Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forge): only cleanup dirs if they exists #194

Merged
merged 3 commits into from
Dec 4, 2021

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Dec 4, 2021

remove_dir_all throws if path does not exists.
only remove them if they exist

Builds off of #195 to use ethers-solc project.cleanup

@mattsse mattsse marked this pull request as draft December 4, 2021 17:07
@gakonst
Copy link
Member

gakonst commented Dec 4, 2021

gakonst/ethers-rs#649 should cargo update ethers and use the helper fn?

@mattsse mattsse marked this pull request as ready for review December 4, 2021 17:38
@gakonst gakonst merged commit c4cbe2e into foundry-rs:master Dec 4, 2021
@grandizzy grandizzy added T-bug Type: bug C-forge Command: forge labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge T-bug Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants