Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report correct fuzz failure case #1017

Merged
merged 2 commits into from
Mar 22, 2022
Merged

fix: report correct fuzz failure case #1017

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a8d6e1
fix: report correct fuzz failure case
onbjerg Mar 22, 2022
b6af89c
docs: improve some docs in fuzzer
onbjerg Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions evm/src/fuzz/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ where
// Stores the consumed gas and calldata of every successful fuzz call
let cases: RefCell<Vec<FuzzCase>> = RefCell::new(Default::default());

// Stores the result of the last call
let call: RefCell<RawCallResult> = RefCell::new(Default::default());
// Stores the result of the last failed call, if any.
onbjerg marked this conversation as resolved.
Show resolved Hide resolved
let counterexample: RefCell<(Bytes, RawCallResult)> = RefCell::new(Default::default());

// Stores fuzz state for use with [fuzz_calldata_from_state]
let state: EvmFuzzState = build_initial_state(&self.executor.db);
Expand All @@ -74,11 +74,10 @@ where
]);
tracing::debug!(func = ?func.name, should_fail, "fuzzing");
let run_result = self.runner.clone().run(&strat, |calldata| {
*call.borrow_mut() = self
let call = self
.executor
.call_raw(self.sender, address, calldata.0.clone(), 0.into())
.expect("could not make raw evm call");
let call = call.borrow();
let state_changeset =
call.state_changeset.as_ref().expect("we should have a state changeset");

Expand All @@ -105,16 +104,24 @@ where
});
Ok(())
} else {
// We cannot use the calldata returned by the test runner in `TestError::Fail`,
// since that input represents the last run case, which may not correspond with our
// failure - when a fuzz case fails, proptest will try to run at least one more
// case to find a minimal failure case.
*counterexample.borrow_mut() = (calldata, call);
Err(TestCaseError::fail(
match foundry_utils::decode_revert(call.result.as_ref(), errors) {
match foundry_utils::decode_revert(
counterexample.borrow().1.result.as_ref(),
errors,
) {
Ok(e) => e,
Err(_) => "".to_string(),
},
))
}
});

let call = call.into_inner();
let (calldata, call) = counterexample.into_inner();
let mut result = FuzzTestResult {
cases: FuzzedCases::new(cases.into_inner()),
success: run_result.is_ok(),
Expand All @@ -129,7 +136,7 @@ where
Err(TestError::Abort(reason)) => {
result.reason = Some(reason.to_string());
}
Err(TestError::Fail(reason, calldata)) => {
Err(TestError::Fail(reason, _)) => {
let reason = reason.to_string();
result.reason = if reason.is_empty() { None } else { Some(reason) };

Expand Down