Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support int for type in transactions #4240

Closed
2 tasks
Tracked by #8269
antazoey opened this issue Jan 31, 2023 · 2 comments
Closed
2 tasks
Tracked by #8269

Support int for type in transactions #4240

antazoey opened this issue Jan 31, 2023 · 2 comments
Labels
A-compatibility Area: compatibility C-anvil Command: anvil T-bug Type: bug

Comments

@antazoey
Copy link

Component

Anvil

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

foundryup: installed - anvil 0.1.0 (5c2db0b 2023-01-31T00:18:27.342972Z)

What command(s) is the bug in?

RPC for sending txn

Operating System

macOS (Intel)

Describe the bug

To increase compatibility with web3.py, allow integer for type in transaction.
https://github.com/ethereum/web3.py/blob/master/web3/types.py#L224

This will allow HTTP clients to be simpler and use integers.

@antazoey antazoey added the T-bug Type: bug label Jan 31, 2023
@onbjerg onbjerg added the C-anvil Command: anvil label Feb 27, 2023
@zerosnacks zerosnacks added the A-compatibility Area: compatibility label Jun 28, 2024
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 26, 2024
@grandizzy grandizzy removed this from the v1.0.0 milestone Nov 19, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Nov 19, 2024
@grandizzy
Copy link
Collaborator

@antazoey could you please clarify the issue / send a way to reproduce? thank you!

@DaniPopes
Copy link
Member

DaniPopes commented Nov 19, 2024

I'm guessing referring to this:

                if isinstance(txn_dict.get("type"), int):
                    txn_dict["type"] = HexBytes(txn_dict["type"]).hex()

The type field in transactions is specified as a hex-encoded integer. This has always been the standard.

@DaniPopes DaniPopes closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compatibility Area: compatibility C-anvil Command: anvil T-bug Type: bug
Projects
Archived in project
Development

No branches or pull requests

5 participants