Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete hack #123

Merged
merged 3 commits into from
Feb 3, 2023
Merged

chore: delete hack #123

merged 3 commits into from
Feb 3, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Feb 1, 2023 •
edited by NotPeopling2day
Loading

What I did

fixes: APE-567

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey mentioned this pull request Feb 1, 2023
Merged
3 tasks
@antazoey
Copy link
Member Author

antazoey commented Feb 1, 2023

requires ApeWorX/ape#1276

@antazoey antazoey requested review from NotPeopling2day and a user February 1, 2023 20:13
@antazoey
Copy link
Member Author

antazoey commented Feb 1, 2023

sorry, comment about foundry was meant to go to foundry plugin

@antazoey antazoey requested a review from fubuloubu February 1, 2023 23:52
fubuloubu
fubuloubu approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heckuva hack

@antazoey antazoey merged commit ff37981 into ApeWorX:main Feb 3, 2023
@antazoey antazoey deleted the chore/deletehack branch February 3, 2023 14:11
@antazoey
Copy link
Member Author

antazoey commented Feb 3, 2023

heckuva hack

for reference, the hack was copying come code from core and changing one thing about.
So not as intense as it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotPeopling2day NotPeopling2day NotPeopling2day approved these changes

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antazoey @fubuloubu @NotPeopling2day