Remove unneeded clone

foundry-rs · Nov 11, 2024 · 6f50c3c · 6f50c3c
1 parent 83559eb
commit 6f50c3c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/crates/cast/bin/cmd/artifact.rs b/crates/cast/bin/cmd/artifact.rs
@@ -57,8 +57,8 @@ impl ArtifactArgs {
         let config = Config::from(&rpc);
         let provider = utils::get_provider(&config)?;
 
-        let abi = if let Some(abi_path) = abi_path.clone() {
-            load_abi_from_file(&abi_path, None)?
+        let abi = if let Some(ref abi_path) = abi_path {
+            load_abi_from_file(abi_path, None)?
         } else {
             fetch_abi_from_etherscan(contract, &etherscan).await?
         };
@@ -67,7 +67,8 @@ impl ArtifactArgs {
 
         let bytecode = fetch_creation_code(contract, client, provider).await?;
         let bytecode =
-            parse_code_output(bytecode, contract, &etherscan, abi_path, true, false).await?;
+            parse_code_output(bytecode, contract, &etherscan, abi_path.as_deref(), true, false)
+                .await?;
 
         let artifact = json!({
             "abi": abi,

diff --git a/crates/cast/bin/cmd/creation_code.rs b/crates/cast/bin/cmd/creation_code.rs
@@ -59,9 +59,15 @@ impl CreationCodeArgs {
 
         let bytecode = fetch_creation_code(contract, client, provider).await?;
 
-        let bytecode =
-            parse_code_output(bytecode, contract, &etherscan, abi_path, without_args, only_args)
-                .await?;
+        let bytecode = parse_code_output(
+            bytecode,
+            contract,
+            &etherscan,
+            abi_path.as_deref(),
+            without_args,
+            only_args,
+        )
+        .await?;
 
         if disassemble {
             let _ = sh_println!("{}", SimpleCast::disassemble(&bytecode)?);
@@ -81,7 +87,7 @@ pub async fn parse_code_output(
     bytecode: Bytes,
     contract: Address,
     etherscan: &EtherscanOpts,
-    abi_path: Option<String>,
+    abi_path: Option<&str>,
     without_args: bool,
     only_args: bool,
 ) -> Result<Bytes> {
@@ -90,7 +96,7 @@ pub async fn parse_code_output(
     }
 
     let abi = if let Some(abi_path) = abi_path {
-        load_abi_from_file(&abi_path, None)?
+        load_abi_from_file(abi_path, None)?
     } else {
         fetch_abi_from_etherscan(contract, etherscan).await?
     };