chore: unpin nightly in ci, clippy (#7345)

.github/workflows/test.yml

@@ -133,8 +133,6 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@clippy
-        with:
-          toolchain: nightly-2024-02-03
       - uses: Swatinem/rust-cache@v2
         with:
           cache-on-failure: true

crates/config/src/lib.rs

@@ -963,7 +963,7 @@ impl Config {
                 (Ok(mut config), Some(key)) => {
                     // we update the key, because if an etherscan_api_key is set, it should take
                     // precedence over the entry, since this is usually set via env var or CLI args.
-                    config.key = key.clone();
+                    config.key.clone_from(key);
                     return Ok(Some(config))
                 }
                 (Ok(config), None) => return Ok(Some(config)),

crates/evm/core/src/backend/snapshot.rs

@@ -39,7 +39,7 @@ impl<T> BackendSnapshot<T> {
     /// journaled_state includes the same logs, we can simply replace use that See also
     /// `DatabaseExt::revert`
     pub fn merge(&mut self, current: &JournaledState) {
-        self.journaled_state.logs = current.logs.clone();
+        self.journaled_state.logs.clone_from(&current.logs);
     }
 }
 

crates/evm/evm/src/executors/invariant/mod.rs

@@ -236,7 +236,7 @@ impl<'a> InvariantExecutor<'a> {
                         );
 
                     if !can_continue || current_run == self.config.depth - 1 {
-                        *last_run_calldata.borrow_mut() = inputs.clone();
+                        last_run_calldata.borrow_mut().clone_from(&inputs);
                     }
 
                     if !can_continue {

crates/evm/traces/src/decoder/mod.rs

@@ -189,7 +189,7 @@ impl CallTraceDecoder {
 
         let default_labels = &Self::new().labels;
         if self.labels.len() > default_labels.len() {
-            self.labels = default_labels.clone();
+            self.labels.clone_from(default_labels);
         }
 
         self.receive_contracts.clear();

crates/script/src/lib.rs

@@ -605,7 +605,6 @@ impl ScriptConfig {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use foundry_cli::utils::LoadConfig;
     use foundry_config::{NamedChain, UnresolvedEnvVarError};
     use std::fs;
     use tempfile::tempdir;

crates/script/src/sequence.rs

@@ -365,7 +365,7 @@ impl ScriptSequence {
         self.transactions
             .iter_mut()
             .enumerate()
-            .for_each(|(i, tx)| tx.rpc = sensitive.transactions[i].rpc.clone());
+            .for_each(|(i, tx)| tx.rpc.clone_from(&sensitive.transactions[i].rpc));
     }
 }