Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add IS_TEST = true to Test #523

Merged
merged 2 commits into from
Mar 17, 2024
Merged

fix: add IS_TEST = true to Test #523

merged 2 commits into from
Mar 17, 2024

Conversation

mds1
Copy link
Collaborator

@mds1 mds1 commented Mar 15, 2024 •
edited
Loading

Closes #522

This used to come from ds-test, and v1.8.0 of forge-std removed that dependency

@mds1 mds1 requested a review from klkvr March 15, 2024 22:16
mattsse
mattsse approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works, we use this as an additional check to identify test contracts on the abi level,

https://github.com/foundry-rs/foundry/blob/42da94276892f63afefd0dc743e862b058a4b4c2/crates/common/src/compile.rs#L255-L257

we do the same for Script.sol

@mattsse mattsse mentioned this pull request Mar 16, 2024
Merged
@mds1 mds1 merged commit bb4ceea into master Mar 17, 2024
3 checks passed
@DaniPopes DaniPopes deleted the fix/is-test branch October 24, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DSTest removal in v1.8.0 seems to break the forge contract sizer filter
3 participants
@mds1 @mattsse @klkvr