fix(tutorial): Fixed example tests in NFT tutorial #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In this pull request, I've addressed the issue where the NFT tutorial tests were utilizing the older version of the etch cheatcode. The behavior of the etch cheatcode was recently altered in foundry-rs/foundry#4905, making the existing NFT tutorial tests incompatible.
Solution:
This should ensure that the NFT tutorial is now up-to-date and functions as expected with the latest changes in the foundry-rs repository.
Please review the changes and provide insights, especially regarding the address change to the 11th. Let me know if any further modifications are required.