Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove line causing docker build issues #774

Merged

Conversation

kprosise
Copy link
Contributor

Removed line reported to be causing issues due to no longer being required for secrets.

QA: Ran linter, linkcheck, and viewed rendered HTML.

This commit relates to FS-2820: "…Docker Build Stages Not Caching…"

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Removed line reported to be causing issues due to no longer being
required for secrets.

QA: Ran linter, linkcheck, and viewed rendered HTML.

This commit relates to FS-2820: "…Docker Build Stages Not Caching…"

Signed-off-by: Katrina Prosise <[email protected]>
@doanac
Copy link
Member

doanac commented Nov 22, 2024

@kprosise
Copy link
Contributor Author

Linkcheck error not related to changes and is no longer an issue, can be ignored.

@kprosise kprosise merged commit 68178d1 into foundriesio:main Dec 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants