Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyperlinks from pr-699 #761

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

kprosise
Copy link
Contributor

References and external links fixed to use correct syntax. Also minor grammar fix on a line containing one of the broken links.

No related tickets, quick fix.

QA: ran linkcheck and viewed rendered html.

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

References and external links fixed to use correct syntax.
Also minor grammar fix on a line containing one of the broken links.

No related tickets, quick fix.

QA: ran linkcheck and viewed rendered html.

Signed-off-by: Katrina Prosise <[email protected]>
@doanac
Copy link
Member

doanac commented Oct 17, 2024

@kprosise kprosise merged commit f254926 into foundriesio:main Oct 17, 2024
2 of 3 checks passed
@kprosise kprosise deleted the fix-hyperlinks branch October 17, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants