fix(release): added known issue text to release notes #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs for 2a046f1 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2578/docs/artifacts/html/index.html |
kprosise
reviewed
Jan 30, 2024
source/release-notes/rn_v92.inc
Outdated
| Known Issues | ||
| ------------ | ||
|
|
||
| There is now a known issue with regards to `fioconfig` and the handler it executes whenever the config is changed. |
There was a problem hiding this comment.
Suggested change
| There is now a known issue with regards to `fioconfig` and the handler it executes whenever the config is changed. | |
| There is now a known issue with regards to ``fioconfig`` and the handler it executes whenever the config is changed. |
kprosise
approved these changes
Jan 30, 2024
source/release-notes/rn_v92.inc
Outdated
| ------------ | ||
|
|
||
| There is now a known issue with regards to `fioconfig` and the handler it executes whenever the config is changed. | ||
| The handler in question `aktualizr-toml-update` currently expects a default location for the `sota.toml` file. |
There was a problem hiding this comment.
Suggested change
| The handler in question `aktualizr-toml-update` currently expects a default location for the `sota.toml` file. | |
| The handler in question, ``aktualizr-toml-update``, currently expects a default location for the ``sota.toml`` file. |
source/release-notes/rn_v92.inc
Outdated
Comment on lines
30
to
31
| However if the directory that contains the `sota.toml` is changed due to configuration this may result in an error | ||
| thrown by the handler stating it cannot find `sota.toml` whenever running a `fioconfig` change. This has been patched |
There was a problem hiding this comment.
Suggested change
| However if the directory that contains the `sota.toml` is changed due to configuration this may result in an error | |
| thrown by the handler stating it cannot find `sota.toml` whenever running a `fioconfig` change. This has been patched | |
| However if the directory that contains the ``sota.toml`` is changed due to configuration, this may result in an error | |
| thrown by the handler stating it cannot find ``sota.toml``, whenever running a ``fioconfig`` change. This has been patched |
source/release-notes/rn_v92.inc
Outdated
| However if the directory that contains the `sota.toml` is changed due to configuration this may result in an error | ||
| thrown by the handler stating it cannot find `sota.toml` whenever running a `fioconfig` change. This has been patched | ||
| in the following `commit`_. That patch will ensure the handler from then on uses whichever directory has been configured | ||
| to hold the `sota.toml` file. |
There was a problem hiding this comment.
Suggested change
| to hold the `sota.toml` file. | |
| to hold the ``sota.toml`` file. |
angolini
approved these changes
Jan 30, 2024
|
What identifier should I add for future references? Is there a predetermined format we should use or do we need to come up with one now? 👍 |
Signed-off-by: Eric Bode <[email protected]>
StealthyCoder
force-pushed
the
fix/known_issue_v92
branch
from
2a046f1 to
4b1e8a8
Compare
|
Docs for 4b1e8a8 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2587/docs/artifacts/html/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness
Overview
Added a known issues text to the release notes concerning the handler logic for
fioconfig.Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."
make linkcheck.-s, --signoff).-S, --gpg-sign).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.