Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: qemu: clarify how to emulate multiple devices #616

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

camilamacedo86
Copy link
Contributor

Signed-off-by: Camila Macedo [email protected]

Readiness

  • [x ] Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

@doanac
Copy link
Member

doanac commented Oct 23, 2023

@doanac
Copy link
Member

doanac commented Oct 23, 2023

@doanac
Copy link
Member

doanac commented Oct 23, 2023

Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions, otherwise it LGTM.

source/getting-started/emulation-with-qemu/index.rst Outdated Show resolved Hide resolved
source/reference-manual/qemu/qemu-instructions.template Outdated Show resolved Hide resolved
@doanac
Copy link
Member

doanac commented Oct 23, 2023

Copy link
Collaborator

@angolini angolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

few minor suggestion

source/getting-started/emulation-with-qemu/index.rst Outdated Show resolved Hide resolved
source/reference-manual/qemu/qemu-instructions.template Outdated Show resolved Hide resolved
Signed-off-by: Camila Macedo <[email protected]>
Co-authored-by: Katrina Prosise <[email protected]>
Co-authored-by: Daiane Angolini <[email protected]>
@doanac
Copy link
Member

doanac commented Oct 25, 2023

@doanac
Copy link
Member

doanac commented Oct 25, 2023

@kprosise kprosise merged commit 1d917c4 into foundriesio:main Oct 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants