-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: qemu: clarify how to emulate multiple devices #616
Conversation
Docs for 33ab1ac are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2436/docs/artifacts/html/index.html |
33ab1ac
to
787d58b
Compare
Docs for 787d58b are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2437/docs/artifacts/html/index.html |
787d58b
to
fa922b7
Compare
Docs for fa922b7 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2438/docs/artifacts/html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple suggestions, otherwise it LGTM.
3fecc08
to
39afe3b
Compare
Docs for 39afe3b are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2441/docs/artifacts/html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
few minor suggestion
Signed-off-by: Camila Macedo <[email protected]> Co-authored-by: Katrina Prosise <[email protected]> Co-authored-by: Daiane Angolini <[email protected]>
ea34ffa
to
a4e6df0
Compare
Docs for a4e6df0 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2445/docs/artifacts/html/index.html |
Co-authored-by: Katrina Prosise <[email protected]>
Docs for 4344cfe are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2446/docs/artifacts/html/index.html |
Signed-off-by: Camila Macedo [email protected]
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.