Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid reveal modal closing upon click of an element not in the DOM #9146

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Avoid reveal modal closing upon click of an element not in the DOM #9146

merged 1 commit into from
Sep 26, 2016

Commits on Aug 31, 2016

  1. Avoid reveal modal closing upon click of an element not in the DOM 

    Added check to make sure e.target is still in the DOM. I came across a bug when I created a google map canvas inside reveal modal, whereby upon closing the info popup on a map marker, the entire reveal modal gets closed. This is because when the overlay click handler is invoked, Google code has already removed the e.target  element and the overlay handler only gets a ghost element and can not find it in the modal element
    @ardeshireshghi
    ardeshireshghi authored Aug 31, 2016
    Configuration menu
    Copy the full SHA
    5cc02a8 View commit details
    Browse the repository at this point in the history