orbit: add/trigger event beforeslidechange #9141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I use this event to smoothly resize the orbit container for carousels with images of different heights
|
Looks good. This is an event that makes a ton of sense for Orbit, regardless of the resize issue. We're talking about doing a lifecycle/event standardization and audit across all of our plugins; @coreysyms when you get a first pass on that lets loop in @pine3ree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this event to smoothly resize the orbit container for carousels having images with different heights.
the callback will receive 2 arguments: the current slide and the next slide.