Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.3 [new feature] responsiveAccordionTabs #8774

Merged
merged 2 commits into from
Oct 31, 2016

Conversation

designerno1
Copy link
Contributor

#8651

@zurb/yetinauts
maybe some native english speaker could take a look at the docs page english

@@ -0,0 +1,112 @@
---
title: Responsive Accordion Tabs
description: Use the Markup of a Accordion or Tabs and create a Responsive Accordion Tabs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Use the markup of the Accordion or Tabs components to create Responsive Accordion Tabs."

@designerno1
Copy link
Contributor Author

designerno1 commented May 11, 2016

@colin-marshall
just added
Accordion markup should have an ID, if no ID is present, an ID is autogenerated for switch to Tabs.<br>Also the accordion-content should have an ID, or the # of the href should be specified, otherwise a digit6-accordion random is generated to switch to the right Tab on change.
good? ;-)

@colin-marshall
Copy link
Contributor

colin-marshall commented May 11, 2016

First sentence:
The Accordion should have an id specified, but the plugin will automatically generate one if the id is omitted.

The second sentence also needs revising. I think I know what you're saying but am not positive. I will have to come back to this when I have a minute to dig into the functionality of this new component.

@designerno1 designerno1 changed the title first commit on feature responsiveAccordionTabs v6.3 [new feature] responsiveAccordionTabs May 11, 2016
@rafibomb
Copy link
Member

Damn - this is a hot feature! Let's get this across the line for 6.3. @colin-marshall Great feedback!

@designerno1 How can we support you on this?

@designerno1
Copy link
Contributor Author

@rafibomb
some real example testing could be fine, if there should be JS Unit Test it would be great if someone could support the feature there

@kball
Copy link
Contributor

kball commented Oct 5, 2016

@Owlbertz can you take a dig into this, particularly with the unit testing in mind as you've been doing such good work on other unit tests?

@kball
Copy link
Contributor

kball commented Oct 31, 2016

Given that all we are lacking at this point is testing, I'm going to add @colin-marshall's docs feedback and merge this to make it easier to test.

@kball kball merged commit 0bf7690 into foundation:v6.3 Oct 31, 2016
@kball
Copy link
Contributor

kball commented Oct 31, 2016

Merged!

@designerno1 designerno1 deleted the v6.3-responsiveAccordionTabs branch November 1, 2016 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants