changed.zf.mediaquery improvements #8644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this.current = newSize; (should be set before window triggered because if something goes wrong changed.zf.mediaquery fires constantly)
| // Change the current media query | ||
| this.current = newSize; | ||
|
|
||
| // Broadcast the media query change on the window | ||
| $(window).trigger('changed.zf.mediaquery', [newSize, this.current]); |
There was a problem hiding this comment.
Triggering it here means this.current is newSize, rather than the old size. I think moving this to after the set is reasonable, but if we do we should capture the previous value of this.current and pass it as the second value.
|
ah ok i see, the only thing this PR was for i ran into an error on my |
|
@designerno1 do you have time to clean up this PR to address the problem raised in the comment? I'd love to get this fix in place |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.current = newSize; (should be set before window triggered because if something goes wrong changed.zf.mediaquery fires constantly, because current is neer set