Enhance keyboard util. #8571
Merged
Enhance keyboard util. #8571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced keyboard util by adding a parameter that is passed to the `handled` function based on the evaluation of the function that was handled. It is now easier to only do certain actions (e.g. calling `preventDefaul()`) in the `handled` handler by letting the other function (e.g. `next`, `up`, ...) return some value, which is directly passed into `handled` as the first parameter. I also adjusted the calls to the keyboard util for some plugins to fix issues and prevent bad behavior.
|
This looks good, I'll try to find some time to test it out in the next day or two |
|
Checks out, looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced keyboard util by adding a parameter that is passed to the
handledfunction based on the evaluation of the function that was handled.It is now easier to only do certain actions (e.g. calling
preventDefaul()) in thehandledhandler by letting the other function (e.g.next,up, ...) return some value, which is directly passed intohandledas the first parameter.I also adjusted the calls to the keyboard util for some plugins to fix issues and prevent bad behavior.
Since this rework fixes some bugs (#8535, #8569) I will target the develop branch.