Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update foundation.tooltip.js to enable to parse a postionClass when c… #8567

Merged
merged 1 commit into from
May 4, 2016

Conversation

JamesJGarner
Copy link
Contributor

Before submitting a pull request, make sure it's targeting the right branch:

  • For documentation fixes, use master.
  • For bug fixes, use develop.
  • For new features, use the branch for the next minor version, which will be formatted v6.x.

If you're fixing a JavaScript issue, it would help to create a new test case under the folder test/visual/ that recreates the issue and show's that it's been fixed. Run npm test to compile the testing folder.

Happy coding! :)

…reating Tooltips using js

Changed code so the positionClass checks inside this.options rather than just looking at the elements css

…reating Tooltips using js

Changed code so the positionClass checks inside this.options rather than just looking at the elements css
@kball
Copy link
Contributor

kball commented May 4, 2016

Seems reasonable to me

@kball kball merged commit 26a6640 into foundation:develop May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants