Dropdown menu fixes #8564
Merged
Dropdown menu fixes #8564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the selectors were not specific enough, the styles of .opens-right set by the JS in case of an overflowing sub-menu was overwritten by the parent's .open-left styles. Added visual tests to check for this. The tests include two cases: one for a right aligned dropdown using `.top-bar-right` (which was fixed earlier already) and one that is positioned right because of content (where this fix can be tested). Also added anchors to the menu's links to check for correct behavior of the links, e.g. when using keyboard.
Fixes behaviour for vertical menus to be correct (switch left/right with up/down compared to horizontal menus). Fixed usage of `e.preventDefault()` to enable opening of links in the menu.
|
I think, the arrows are still in the wrong direction. see: |
|
This looks good as a JS fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for detection of overfloating dropdown menus.
Fixes #8555.
Also fixes the behavior for keyboard navigation with vertical menus.
Fixed keyboard interaction for dropdown menu.
Addresses #8480 (comment).
Added test cases for this, the second menu bar reflects the changes made in this PR.