fix(react-helmet): use react-helmet-async to fix console error #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aman-Codes
force-pushed
the
fix/console-error
branch
from
215cd00 to
af837ce
Compare
github-actions
bot
added
the
has merge conflicts
|
This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request. |
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Aman-Codes
force-pushed
the
fix/console-error
branch
from
af837ce to
e237eb5
Compare
github-actions
bot
removed
the
has merge conflicts
GMishx
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed error in console due to the use of
react-helmetlibrary. Also listed as an issue in nfl/react-helmet#548Changes
react-helmetwithreact-helmet-asyncScreenshots
Before
After
How to test
Check console for error