Removed MVVM Light #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimGels
force-pushed
the
replace-mvvmlight
branch
4 times, most recently
from
0d143c3 to
19dc6f0
Compare
Removed the MVVMLight package as it is deprecated and added the Microsoft.Toolkit.Mvvm package as the successor. Some implementations had to be redone as MVVM Toolkit didn't provide a drop in replacement. An example for such case is the clearing/ unregistering of a viewmodel. I have added a method in the code behind of the main page that checks if it will navigate to the login page. If that is the case, it clears the navigation cache resulting in all cached pages being cleared (except for the pages using the 'required' navigation cache mode). The reason I added the cache mode enabled to the main page is so that users don't have to navigato through their directories after navigation back to the main page after every navigation.
TimGels
force-pushed
the
replace-mvvmlight
branch
from
19dc6f0 to
bc5c4e3
Compare
On master, at step 4, the volume slider is at 100, while this branch has a regression where the slider goes to 0 even though there is audio playing. |
I can reproduce this. Yes this seems to be a regression in the way how the VM is kept or not kept in memory or something. |
With MVVMLight, the static volumeUpdated was initialized to false on every navigation action to the page. With the new navigation, the static volumeUpdated actually held it's value which resulted in the volume not being updated after navigating to the page for a second time. This has been fixed by making the variable not static, so it is initialized every time correctly. Also added an assertion to self-document this, and added clarification comment.
TimGels
force-pushed
the
replace-mvvmlight
branch
from
77158d9 to
fce3d53
Compare
JohannesKauffmann
force-pushed
the
replace-mvvmlight
branch
from
fce3d53 to
57cc720
Compare
JohannesKauffmann
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the MVVMLight package as it is deprecated and added the Microsoft.Toolkit.Mvvm package as the successor. Some implementations had to be redone as MVVM Toolkit didn't provide a drop in replacement. An example for such case is the clearing/ unregistering of a viewmodel.
I have added a method in the code behind of the main page that checks if it will navigate to the login page. If that is the case, it clears the navigation cache resulting in all cached pages being cleared (except for the pages using the 'required' navigation cache mode). The reason I added the cache mode enabled to the main page is so that users don't have to navigate through their directory, after navigating back to the main page after every navigation.
Reference: #66