Fix various memory leaks #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related issue is #40. VideoPlayerPageViewModel: - chg: Instead of lambda's, event handlers are now used for all events, including timers. The fileNameOverlayTimer has been moved to the top and made readonly, so it is only initialized once. Also, some comments have been split over multiple lines. - fix: The fileNameOverlayTimer is now only once instead of every 5 seconds. Views/VideoPlayerPage.xaml.cs: - chg: Unsubscribe from events using event handlers instead of lambda's. Some comments have been split over multiple lines.
Related issue is #40. App.xaml.cs: - add: Global UI dispatcher property, so every class can access the UI conventiently. VideoPlayerPageViewModel.cs: - rem: Unneeded using system.diagnostics. VideoPlayerPage.xaml.cs: - chg: Dispose the media after playing it by wrapping it in a using. This follows the official LibVLCSharp UWP sample. Replaced lengthy dispatcher calls with App.Current.
|
Merging even though it doesn't fix #40. At least there is now a precedent of unsubscribing from event handlers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix various memory leaks such as undisposed media and not unsubscribing from event handlers.