Don't route on proposed ways #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Routing on proposed ways was blacklisted only for car profile. This adds the same blacklisting also for foot and bike profiles. It looks like this behavior was added in Project-OSRM/osrm-backend#4258 and then accidentally reverted when pull request with title "profiles api v2" at Project-OSRM/osrm-backend#4072 was merged. This commit restores the original change for bike and foot profiles.
|
The pull request in upstream was just merged. It would be nice to have this fix also in this repository and on openstreetmap.org. |
|
Sorry, my todo list is too long at the moment. But I should prioritize things when someone is actually doing work for me :) Should show up in a few days on the server |
|
It's understandable. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routing on proposed ways was blacklisted only for car profile. This adds the same blacklisting also for foot and bike profiles.
It looks like this behavior was added in Project-OSRM/osrm-backend#4258 and then accidentally reverted when pull request at Project-OSRM/osrm-backend#4072 was merged. This commit restores the original change for bike and foot profiles.
There is also an open pull request on the upstream osrm-backend repository: Project-OSRM/osrm-backend#6615
It includes automated tests for these cases and references a GitHub issue that has more background information.